Skip to content

fix: add mkdir step for build-html script#20

Open
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
TusharThakur04:fix/build-html-command
Open

fix: add mkdir step for build-html script#20
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
TusharThakur04:fix/build-html-command

Conversation

@TusharThakur04
Copy link

Summary
This PR adds mkdir -p out to the build-html script so the directory is created automatically before doc-kit runs.

  • it makes dev convenient.

Reproduce

Screenshot from 2026-03-13 19-55-05

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI
no

@avivkeller
Copy link
Member

avivkeller commented Mar 13, 2026

cc @ovflowd we should probably create the output directory in doc-kit, tbh. I think we can implement that as a part of recursive file creation, which is my TODO for this weekend.

Also, this isn't a cross-platform solution.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are reasons of why doc-kit does not create the directory for you, as many other tools out there, as it is not its job to manage the filesystem for you.

At times you want the directory to be created under a different account, or different chmod, or you accidentally left a directory that doesn't exist anymore, this will err on that.

So Im fundamentally -1 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants