fix: add mkdir step for build-html script#20
Open
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
Open
fix: add mkdir step for build-html script#20TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
Conversation
Member
|
cc @ovflowd we should probably create the output directory in doc-kit, tbh. I think we can implement that as a part of recursive file creation, which is my TODO for this weekend. Also, this isn't a cross-platform solution. |
ovflowd
requested changes
Mar 13, 2026
Member
ovflowd
left a comment
There was a problem hiding this comment.
There are reasons of why doc-kit does not create the directory for you, as many other tools out there, as it is not its job to manage the filesystem for you.
At times you want the directory to be created under a different account, or different chmod, or you accidentally left a directory that doesn't exist anymore, this will err on that.
So Im fundamentally -1 with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
mkdir -p outto thebuild-htmlscript so the directory is created automatically before doc-kit runs.Reproduce
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
no