Open
Conversation
* feat: enable cacheImmutable by default * fix: thoses files shouldn't immutable * fix: update cache control logic becauses undefined !== false (true) * test: add tests for cacheControl option behavior with cacheImmutable set to false * refactor: normalize cacheControl handling in response headers * refactor: simplify maxAge calculation in cacheControl handling
…ned` when not found
…ddleware (#2259) * feat: add `forwardError` option to enable error forwarding to next middleware * feat: add error middleware support in frameworkFactory for improved error handling * feat: enhance error handling by removing response headers before forwarding errors * feat: remove error middleware option from frameworkFactory for cleaner middleware setup * test: update middleware tests to reflect changes in error handling with forwardError option * test: update middleware tests to handle error forwarding for hapi framework * feat: implement error forwarding in koa middleware and update tests accordingly * feat: add error forwarding support in hono middleware and update tests accordingly * feat: add forwardError option to README with usage example
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
+ Coverage 95.88% 96.92% +1.03%
==========================================
Files 13 13
Lines 900 942 +42
Branches 270 274 +4
==========================================
+ Hits 863 913 +50
+ Misses 37 29 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Sometimes |
Member
Author
|
@bjohansebas I will make a webpack-cli release and focus on it, there are three things left:
I will take care about them, so you can focus on webpack-dev-server more |
Member
|
Okay, but for compile.validate, we need webpack to release that support. The PR was already merged in webpack, but it’s not officially published on npm yet, so it can’t be updated yet to include that support |
Member
Author
|
@bjohansebas Yeah, I just want to add this check for future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No squash when merging
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI