Skip to content

refactor: fix blocking in span processes #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 3 commits into from
Jan 28, 2026
Merged

refactor: fix blocking in span processes #4637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb3cb27
refactor: fix blocking in span processes
alexander-akait Jan 27, 2026
4c70051
test: debug windows
alexander-akait Jan 27, 2026
d980d77
test: fix
alexander-akait Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/set-blocking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"use strict";

process.stdout._handle.setBlocking(true);
9 changes: 6 additions & 3 deletions scripts/update-docs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const { writeFileSync } = require("node:fs");
const { resolve } = require("node:path");
const { pathToFileURL } = require("node:url");
const { version } = require("webpack-dev-server/package.json");

const [majorDevServerVersion] = version.split(".");
Expand All @@ -8,12 +9,13 @@ const [majorDevServerVersion] = version.split(".");
* @returns {Promise<void>}
*/
async function updateDocs() {
const { execa } = await import("execa");
const { stdout: cliOptions } = await execa(
const { execaNode } = await import("execa");
const { stdout: cliOptions } = await execaNode(
resolve(__dirname, "../packages/webpack-cli/bin/cli.js"),
["--help=verbose", "--no-color"],
{
cwd: __dirname,
nodeOptions: [`--import=${pathToFileURL(resolve(__dirname, "./set-blocking.js"))}`],
},
);

Expand All @@ -24,11 +26,12 @@ async function updateDocs() {
writeFileSync("OPTIONS.md", mdContent);

// serve options
const { stdout: serveOptions } = await execa(
const { stdout: serveOptions } = await execaNode(
resolve(__dirname, "../packages/webpack-cli/bin/cli.js"),
["serve", "--help", "--no-color"],
{
cwd: __dirname,
nodeOptions: [`--import=${resolve(__dirname, "./set-blocking.js")}`],
},
);

Expand Down
Loading