Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
cancel-in-progress: true

strategy:
fail-fast: false
fail-fast: true
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [18.x, 20.x, 22.x, 24.x]
Expand Down
3,207 changes: 2,035 additions & 1,172 deletions package-lock.json

Large diffs are not rendered by default.

12 changes: 0 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,8 @@
"@babel/core": "^7.25.2",
"@babel/preset-env": "^7.25.2",
"@babel/register": "^7.15.8",
"@eslint/js": "^9.28.0",
"@eslint/markdown": "^7.1.0",
"@commitlint/cli": "^20.2.0",
"@commitlint/config-conventional": "^20.2.0",
"@stylistic/eslint-plugin": "^5.0.0",
"@types/jest": "^30.0.0",
"@types/node": "^22.5.5",
"@types/rechoir": "^0.6.1",
Expand All @@ -65,16 +62,8 @@
"del-cli": "^6.0.0",
"eslint": "^9.29.0",
"eslint-config-webpack": "^4.5.0",
"eslint-config-prettier": "^10.1.5",
"eslint-plugin-import": "^2.32.0",
"eslint-plugin-jest": "^29.0.1",
"eslint-plugin-jsdoc": "^61.5.0",
"eslint-plugin-n": "^17.19.0",
"eslint-plugin-prettier": "^5.4.1",
"eslint-plugin-unicorn": "^62.0.0",
"execa": "^9.6.1",
"get-port": "^7.1.0",
"globals": "^16.2.0",
"husky": "^9.1.4",
"jest": "^30.2.0",
"lerna": "^9.0.3",
Expand All @@ -90,7 +79,6 @@
"ts-loader": "^9.3.1",
"ts-node": "^10.9.1",
"typescript": "^5.0.4",
"typescript-eslint": "^8.35.0",
"webpack": "^5.103.0",
"webpack-bundle-analyzer": "^5.1.0",
"webpack-dev-server": "^5.1.0"
Expand Down
2 changes: 1 addition & 1 deletion test/api/do-install.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const readlineQuestionMock = jest.fn();
jest.mock("node:readline", () => ({
createInterface: jest.fn().mockReturnValue({
question: readlineQuestionMock,
close: jest.fn().mockImplementation(() => undefined),
close: jest.fn().mockReturnValue(undefined),
}),
}));

Expand Down
4 changes: 2 additions & 2 deletions test/create-webpack-app/test.utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function createPathDependentUtils(cli) {
/**
* Run the webpack CLI for a test case.
* @param {string} cwd The path to folder that contains test
* @param {Array<string>} args Array of arguments
* @param {string[]} args Array of arguments
* @param {TestOptions} options Options for tests
* @returns {Promise<import("execa").Result>} child process
*/
Expand All @@ -27,7 +27,7 @@ function createPathDependentUtils(cli) {
/**
* Run the webpack CLI in watch mode for a test case.
* @param {string} cwd The path to folder that contains test
* @param {Array<string>} args Array of arguments
* @param {string[]} args Array of arguments
* @param {TestOptions} options Options for tests
* @returns {Promise<import("execa").Result>} The webpack output or Promise when nodeOptions are present
*/
Expand Down
6 changes: 2 additions & 4 deletions test/info/additional-package.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ describe("'-a, --additional-package <value...>' usage", () => {
expect(stdout).toContain("pnpm");
expect(stdout).toContain("typescript");
expect(stdout).toContain("eslint");
expect(stdout).toContain("eslint-config-prettier");
expect(stdout).toContain("eslint-plugin-n");
expect(stdout).toContain("eslint-config-webpack");
});

it("should work with multiple packages using '-a' alias", async () => {
Expand All @@ -78,8 +77,7 @@ describe("'-a, --additional-package <value...>' usage", () => {
expect(stdout).toContain("pnpm");
expect(stdout).toContain("typescript");
expect(stdout).toContain("eslint");
expect(stdout).toContain("eslint-config-prettier");
expect(stdout).toContain("eslint-plugin-n");
expect(stdout).toContain("eslint-config-webpack");
});

it("should throw an error on invalid usage", async () => {
Expand Down
6 changes: 3 additions & 3 deletions test/utils/test-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const processKill = (process) => {
* Webpack CLI test runner.
* @param {import("execa")} execa execa API
* @param {string} cwd The path to folder that contains test
* @param {Array<string>=} args Array of arguments
* @param {string[]=} args Array of arguments
* @param {TestOptions=} options Options for tests
* @returns {import("execa").Result} child process
*/
Expand All @@ -61,7 +61,7 @@ const createProcess = ({ execaNode, execa }, cwd, args, options) => {
/**
* Run the webpack CLI for a test case.
* @param {string} cwd The path to folder that contains test
* @param {Array<string>=} args Array of arguments
* @param {string[]=} args Array of arguments
* @param {TestOptions=} options Options for tests
* @returns {Promise<import("execa").Result>} child process
*/
Expand All @@ -73,7 +73,7 @@ const run = async (cwd, args = [], options = {}) => {
/**
* Run the webpack CLI in watch mode for a test case.
* @param {string} cwd The path to folder that contains test
* @param {Array<string>=} args Array of arguments
* @param {string[]=} args Array of arguments
* @param {TestOptions=} options Options for tests
* @returns {Promise<import("execa").Result>} The webpack output or Promise when nodeOptions are present
*/
Expand Down
6 changes: 2 additions & 4 deletions test/version/additional-package.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ describe("'-a, --additional-package <value...>' usage", () => {
expect(stdout).toContain("pnpm");
expect(stdout).toContain("typescript");
expect(stdout).toContain("eslint");
expect(stdout).toContain("eslint-config-prettier");
expect(stdout).toContain("eslint-plugin-n");
expect(stdout).toContain("eslint-config-webpack");
});

it("should work with multiple packages using '-a' alias", async () => {
Expand All @@ -78,8 +77,7 @@ describe("'-a, --additional-package <value...>' usage", () => {
expect(stdout).toContain("pnpm");
expect(stdout).toContain("typescript");
expect(stdout).toContain("eslint");
expect(stdout).toContain("eslint-config-prettier");
expect(stdout).toContain("eslint-plugin-n");
expect(stdout).toContain("eslint-config-webpack");
});

it("should throw an error on invalid usage", async () => {
Expand Down