Skip benchmark history action in forks#1923
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the benchmarks GitHub Actions workflow to avoid running the benchmark history/comment publishing step in non-upstream repositories (forks), where the benchmark-results branch may not exist, while keeping the PHPBench execution intact.
Changes:
- Adds a repository guard (
if: github.repository == 'webonyx/graphql-php') to thegithub-action-benchmarkstep in the PR benchmarks job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
38
to
40
| - uses: benchmark-action/github-action-benchmark@v1 | ||
| if: github.repository == 'webonyx/graphql-php' | ||
| with: |
Collaborator
Author
There was a problem hiding this comment.
Addressed by adding the same repository guard to the benchmark-history github-action-benchmark step. PHPBench still runs; only history publishing is skipped outside webonyx/graphql-php.
5 tasks
simPod
force-pushed
the
simpod/benchmark-action-fork-guard
branch
from
5434082 to
add6315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skips the benchmark history/comment action when workflows run outside webonyx/graphql-php, where the benchmark-results branch may not exist. The PHPBench run itself still executes.
Failure example https://github.com/simPod/graphql-php/actions/runs/27083416968/job/79933283961