Skip to content

Conversation

@bbrennanbasis
Copy link
Member

@bbrennanbasis bbrennanbasis commented Jan 26, 2026

This PR will closes Issue #658 and improves the overall quality of the RadioButtonGroup article

Version requirements

Testing requires a version of webforJ that's 25.11 or higher.

Changes

  • Added a section for 25.11 nesting feature.
    • Updated samples using RadioButtonGroup to use the nesting feature.
  • Added a section about the RadioButtonGroupChangeEvent.
    • Updated DrawerPlacementView to use RadioButtonGroupChangeEvent and included it on the RadioButtonGroup page.
  • Removed the Usages and Best Practices sections.
  • For DrawerPlacementView, I replaced the switch cases with object data, so onChange() uses the event data and uses fewer trips to the client.

Suggested change

In my opinion, we should also remove the Naming section, or provide a practical example/code snippet that showcases why it's helpful to give a name to a RadioButtonGroup.

- Added a section for nesting feature for 25.11
- Added a section for `RadioButtonGroupChangeEvent`
Comment on lines 73 to 75
## Naming {#naming}

2. **Provide Default Selection**: If applicable, consider providing a default selection for Radio buttons to guide users when they first encounter the options. The default selection should align with the most common or preferred choice.
The name attribute in a `RadioButtonGroup` groups related RadioButtons together, allowing users to make a single choice from the options provided and enforcing exclusivity among the RadioButtons. The name of a group isn't reflected in the DOM, however, and is a convenience utility for the Java developer.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned initially in this PR, we should also remove the Naming section, or provide a practical example/code snippet that showcases why it's helpful to give a name to a RadioButtonGroup.

Suggested change
## Naming {#naming}
2. **Provide Default Selection**: If applicable, consider providing a default selection for Radio buttons to guide users when they first encounter the options. The default selection should align with the most common or preferred choice.
The name attribute in a `RadioButtonGroup` groups related RadioButtons together, allowing users to make a single choice from the options provided and enforcing exclusivity among the RadioButtons. The name of a group isn't reflected in the DOM, however, and is a convenience utility for the Java developer.

@bbrennanbasis bbrennanbasis added status: needs-snapshot Update to the latest snapshot before this PR can be merged. status: waiting-for-review The PR is ready. Waiting for team members to review. labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs-snapshot Update to the latest snapshot before this PR can be merged. status: waiting-for-review The PR is ready. Waiting for team members to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update RadioButtonGroup docs to reflect container nesting support

3 participants