Skip to content

Reflect recent changes in webfactory/html5-tagrewriter #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpdude merged 2 commits into from
Jan 29, 2026
Merged

Reflect recent changes in webfactory/html5-tagrewriter #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf87820
Reflect recent changes in webfactory/html5-tagrewriter
mpdude Jan 29, 2026
f2b1cd8
Fix CS with PHP-CS-Fixer
mpdude Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Twig/Extension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ public function rewriteTags(string $html, ?string $name = null): string
throw new RuntimeException('No TagRewriter registered.');
}

return $tagRewriter->processFragment($html);
return $tagRewriter->processBodyFragment($html);
}
}
6 changes: 4 additions & 2 deletions tests/Fixtures/Handler/TestDefaultHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Webfactory\Html5TagRewriterBundle\Tests\Fixtures\Handler;

use Dom\Element;
use Dom\Node;
use Webfactory\Html5TagRewriter\Handler\BaseRewriteHandler;
use Webfactory\Html5TagRewriterBundle\Attribute\AsRewriteHandler;

Expand All @@ -14,8 +15,9 @@ public function appliesTo(): string
return '//html:p';
}

public function match(Element $element): void
public function match(Node $node): void
{
$element->textContent = 'test-default-handler';
\assert($node instanceof Element);
$node->textContent = 'test-default-handler';
}
}
6 changes: 4 additions & 2 deletions tests/Fixtures/Handler/TestSpecialHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Webfactory\Html5TagRewriterBundle\Tests\Fixtures\Handler;

use Dom\Element;
use Dom\Node;
use Webfactory\Html5TagRewriter\Handler\BaseRewriteHandler;

class TestSpecialHandler extends BaseRewriteHandler
Expand All @@ -17,8 +18,9 @@ public function appliesTo(): string
return '//html:p';
}

public function match(Element $element): void
public function match(Node $node): void
{
$element->textContent = $this->content;
\assert($node instanceof Element);
$node->textContent = $this->content;
}
}
12 changes: 6 additions & 6 deletions tests/Twig/ExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ protected function setUp(): void

public function testFilterUsesDefaultRewriter(): void
{
$this->tagRewriter->method('processFragment')
$this->tagRewriter->method('processBodyFragment')
->with('<p>input</p>')
->willReturn('<p class="processed">output</p>');

Expand All @@ -37,7 +37,7 @@ public function testFilterUsesDefaultRewriter(): void

public function testFilterUsesNamedRewriter(): void
{
$this->tagRewriter->method('processFragment')
$this->tagRewriter->method('processBodyFragment')
->with('<p>input</p>')
->willReturn('<p class="processed">output</p>');

Expand All @@ -49,9 +49,9 @@ public function testFilterUsesNamedRewriter(): void
public function testFilterUsesOnlyDefaultRewriter(): void
{
$defaultRewriter = $this->createStub(TagRewriter::class);
$defaultRewriter->method('processFragment')->with('something')->willReturn('default');
$defaultRewriter->method('processBodyFragment')->with('something')->willReturn('default');
$otherRewriter = $this->createStub(TagRewriter::class);
$otherRewriter->method('processFragment')->willReturn('other');
$otherRewriter->method('processBodyFragment')->willReturn('other');

$this->extension->setDefaultTagRewriter($defaultRewriter);
$this->extension->addTagRewriter('other-rewriter', $otherRewriter);
Expand All @@ -62,9 +62,9 @@ public function testFilterUsesOnlyDefaultRewriter(): void
public function testFilterUsesOnlySpecialRewriter(): void
{
$defaultRewriter = $this->createStub(TagRewriter::class);
$defaultRewriter->method('processFragment')->willReturn('default');
$defaultRewriter->method('processBodyFragment')->willReturn('default');
$otherRewriter = $this->createStub(TagRewriter::class);
$otherRewriter->method('processFragment')->with('something')->willReturn('other');
$otherRewriter->method('processBodyFragment')->with('something')->willReturn('other');

$this->extension->setDefaultTagRewriter($defaultRewriter);
$this->extension->addTagRewriter('other-rewriter', $otherRewriter);
Expand Down