fix: add steps and step-definitions to SPEC_FILE_PATTERN regex#199
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the WebdriverIO DevTools service’s stack-frame filtering to recognize Cucumber step-definition directories, preventing “blank Actions/Source tabs” and avoiding slowdowns caused by failing to resolve user-code stack frames.
Changes:
- Extend
SPEC_FILE_PATTERNto also match/steps/and/step-definitions/directories. - Improve stack-frame detection for Cucumber projects so user command sources can be identified reliably.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| */ | ||
| export const SPEC_FILE_PATTERN = | ||
| /\/(test|spec|features|pageobjects|@wdio\/expect-webdriverio)\//i | ||
| /\/(test|spec|features|steps|step-definitions|pageobjects|@wdio\/expect-webdriverio)\//i |
| @@ -101,7 +101,7 @@ export const CONTEXT_CHANGE_COMMANDS = [ | |||
| * Existing pattern (kept for any external consumers) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cucumber projects using a steps/ or step-definitions/ directory were not
matched by the stack frame filter, causing blank Actions/Source tabs and
slow test runs in the devtools debugger.