Add ObjectPrefixKey wildcard matching for JBFL patterns#185
Merged
Add ObjectPrefixKey wildcard matching for JBFL patterns#185
Conversation
- Add ObjectPrefixKey constructor to NodeSelector - Add ObjectPrefixKey case to compareSB using T.isPrefixOf so JBFL wildcard patterns (e.g. `.foo*`) actually match during formatting - Parse trailing `*` in object keys as ObjectPrefixKey in DSL.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectPrefixKeyconstructor toNodeSelectorso JBFL patterns like.deformGroups_oilPan*can target object keys by prefixcompareSBinNodeCursor.hsto handle prefix matching viaT.isPrefixOf, so wildcard patterns actually match during formatting*in JBFL object key selectors asObjectPrefixKeyin the DSL parser