Fix content showing in sidebar region issue #1160#1161
Closed
Conversation
Contributor
Author
|
I'm closing this PR in favor of PR #1165 - It addresses the issue as well, but fixes a number of other issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes #1160
The issue was that if the sidebar area was blank, no html structure was generated, and so the first content the ilw-columns tag would encounter would be the actual content, which meant it would show the content in the sidebar region.
To solve the issue, I added a
<div>tag around the sidebar area, which forces the sidebar to render and puts the content in the proper place.✅ Peer Review Checklist
Reviewers: Please verify the following before approving.
t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)ksm(),dpm(),console.log) has been removed.