Skip to content

Comments

Add support for incremental backups#1928

Open
dirkkul wants to merge 2 commits intomainfrom
incremental_backup_support
Open

Add support for incremental backups#1928
dirkkul wants to merge 2 commits intomainfrom
incremental_backup_support

Conversation

@dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Jan 22, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 22, 2026 12:11
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for incremental backups to the Weaviate Python client by introducing a new base_backup_id parameter to the backup creation methods. This allows users to create incremental backups based on a previous backup.

Changes:

  • Added base_backup_id parameter to the create method signature across sync and async backup implementations
  • The parameter is mapped to incremental_backup_base_id in the API payload

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
weaviate/backup/executor.py Added base_backup_id parameter to the create method implementation and included it in the backup creation payload
weaviate/backup/sync.pyi Added base_backup_id parameter type hint to the sync backup create method stub
weaviate/backup/async_.pyi Added base_backup_id parameter type hint to the async backup create method stub

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.40%. Comparing base (fd58638) to head (cf7e8d1).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
- Coverage   86.45%   86.40%   -0.06%     
==========================================
  Files         274      275       +1     
  Lines       19966    20001      +35     
==========================================
+ Hits        17261    17281      +20     
- Misses       2705     2720      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants