Open
Conversation
Replace `_root` by constant `self::FRAGMENT_ROOT_TAGNAME`
Try to fix utf-8 encoding problem.
Don't output DocType if only `saveHTML` of elements.
I think we should keep the newline and whitespace.
|
I've ran into the same issue myself now, and this fix would be highly apprectiated. @wasinger Is it possible to get this merged? |
Author
|
I finally gave up this project and wrote my own html dom parse. But I am new on starting up a open source project. |
|
I think it can help you. curl_setopt($ch, CURLOPT_ENCODING, 'UTF-8'); |
Author
|
@kukungkung setting curlopt is just try to request with encoding |
Contributor
|
the problem is not that utf8 is not parsed, just that result is encoded with html entities. i solved this in my code: $html = html_entity_decode((string)$crawler, ENT_NOQUOTES, 'UTF-8'); |
Open
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the urgent need in my project, hope it can help. #18