Fix spec text regarding implicit grouping during translation to algebraic syntax #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
approved these changes
Dec 13, 2025
hartig
approved these changes
Dec 13, 2025
rubensworks
approved these changes
Dec 15, 2025
Contributor
|
@kasei I am not sure why the Echidna run for this PR failed. Somewhere in the stacktrace it says:
But I don't see how the changes in this PR would cause such an error. Maybe it was just a hiccup of the pipeline. Can you post an empty commit to initiate another run of the pipeline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the language used in
18.3.4.1 Grouping and Aggregationregarding the use of implicit grouping. The pseudocode in this section (and previous description in section 11.2) correctly handle implicit grouping if there is aggregation in projection, HAVING, or ORDER BY clauses, but this text previously only mentioned the projection case.Preview | Diff