-
Notifications
You must be signed in to change notification settings - Fork 21
Add certificate serial number (sn) to mDNS TXT record requirements #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This fixes a specification bug where the hostname formation requires the certificate serial number, but it was not being advertised in mDNS TXT records, making it impossible for clients to form the correct hostname for TLS SNI. Resolves the discrepancy between hostname formation requirements and mDNS advertisement specifications.
| `[A-Za-z0-9+/]`. | ||
|
|
||
| : sn | ||
| :: The [=certificate serial number=] of the advertising agent, encoded as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the agent fingerprint insufficent for computing the agent hostname? I also don't see any other reference to TLS SNI in this file, and it's not entirely clear to me why we even need Server Name Indication for this protocol. Can you please provide some additional context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comment below for an improved motivation/overview.
|
I wanted to add a little overview / extended motivation for this PR as I see it. TL;DRThe spec requires TLS SNI = Fix: Add The ProblemThe spec has a dependency chain that breaks at mDNS advertisement: What This Looks Like in PracticeWhy SNI?RFC 6066 Section 3 explains that SNI exists for virtual hosting:
In OSP context (my opinion): A single device could advertise itself in multiple different contexts (e.g., different applications or origins) while sharing the same IP:port. SNI enables this by allowing distinct hostnames per context - which also alligns with browser origin separation where each context needs its own isolated transport identity. Without |
This fixes a specification bug where the hostname formation requires the certificate serial number, but it was not being advertised in mDNS TXT records, making it impossible for clients to form the correct hostname for TLS SNI.
Resolves the discrepancy between hostname formation requirements and mDNS advertisement specifications.