test: add unit tests for pkg/version package#198
Merged
asdek merged 1 commit intovxcontrol:feature/next_releasefrom Mar 20, 2026
Merged
test: add unit tests for pkg/version package#198asdek merged 1 commit intovxcontrol:feature/next_releasefrom
asdek merged 1 commit intovxcontrol:feature/next_releasefrom
Conversation
Add comprehensive unit tests for GetBinaryVersion, IsDevelopMode, and GetBinaryName functions covering all code paths including default values, custom values, and combined version-revision formatting.
There was a problem hiding this comment.
Pull request overview
Adds initial unit test coverage for the backend/pkg/version package, which provides binary name/version and “develop mode” detection used across the application.
Changes:
- Adds unit tests for
GetBinaryVersion()covering default, version-only, revision-only, and version+revision cases. - Adds unit tests for
IsDevelopMode()for both develop and non-develop scenarios. - Adds unit tests for
GetBinaryName()covering default and custom binary names.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Hi, just a friendly ping -- this is a small test-only PR (8 tests for |
Contributor
|
hey @mason5052 thanks for the PR, requests are accepted with a slight delay due to the use of sprints in product development, these are not always urgent changes, I hope for your understanding |
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Problem: The
pkg/versionpackage has no unit test coverage. The package provides binary version, name, and development mode detection used throughout the application.Solution: Add comprehensive unit tests for all three exported functions (
GetBinaryVersion,IsDevelopMode,GetBinaryName) covering all code paths including default values, custom values, and combined version-revision formatting.Type of Change
Areas Affected
Testing and Verification
Test Configuration
Test Steps
go test ./pkg/version/... -vTest Results
Checklist
go fmtandgo vetrun