Conversation
|
The immediate problem becomes - assistive tools will show the clock has 12 options for minutes and seconds with gaps. Not sure if VBtn approach is correct here. Maybe the clock should have role |
6d568d8 to
667b82d
Compare
| .v-time-picker-clock__item--disabled | ||
| opacity: var(--v-disabled-opacity) | ||
| &:focus-visible | ||
| outline: none |
There was a problem hiding this comment.
Outline would definitely help convey the clock is focused. Background color difference is barely visible.
|
|
||
| return ( | ||
| <div | ||
| <VBtn |
There was a problem hiding this comment.
Existing projects might have some customization on .v-btn that could unintentionally leak here. Since the styles would need to be slightly reworked for v4, maybe we should push it all to next?
|
The claim "because tests look ugly" is too weak to justify the risk unintentional styling accidents. E.g. user can make all VBtn have strong shadow and even supplement custom CSS, just to later realize it leaks into this component. Everything else looks good and we could merge without VBtn. |
5b257fd to
86800d9
Compare
fixes #10722, #21885
Description
Markup: