fix(date): allow configure i18n when using custom adapter#265
fix(date): allow configure i18n when using custom adapter#265mmnoori wants to merge 1 commit intovuetifyjs:mainfrom
i18n when using custom adapter#265Conversation
If you want to use a custom date adapter, you can configure it using vuetifyOptions.date.adapter = 'custom'
|
If you've a custom adapter the plugin cannot do the work for you, the user should add the corresponding logic: changes in this PR does nothing since the configuration is empty (check the virtual date module here https://github.com/vuetifyjs/nuxt-module/blob/main/src/vite/vuetify-date-configuration-plugin.ts#L34-L38 and the empty code here https://github.com/vuetifyjs/nuxt-module/blob/main/src/vite/vuetify-date-configuration-plugin.ts#L45) |
|
uhmm, looks like the problem is about i18n, right? |
i18n when using custom adapter
| return | ||
| // if (adapter === 'custom' || !enabled) | ||
| // return | ||
|
|
There was a problem hiding this comment.
shouldn't be
if (!enabled)
return?
There was a problem hiding this comment.
I am using i18n.
i just know when vuetifyOptions.date.adapter is NOT set to 'custom',
configureDate plugin won't change date localization.
I assume your code is right 👍👍👍
There was a problem hiding this comment.
@mmnoori can you explain the problem? changing the code with my previous suggestion will fix the problem you're trying to solve?
If you want to use a custom date adapter, you can configure it using vuetifyOptions.date.adapter = 'custom'