Skip to content

fix: add shared ExtendedToolState for approval states #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cwandev merged 1 commit into from
Dec 23, 2025
Merged

fix: add shared ExtendedToolState for approval states #104

cwandev merged 1 commit into from
Dec 23, 2025

Conversation

@yinjiajun223
Copy link
Contributor

@yinjiajun223 yinjiajun223 commented Dec 11, 2025

  • Create shared types.ts for ExtendedToolState definition
  • Fix TypeScript errors in ToolStatusBadge and Confirmation components
  • Add type safety for 'approval-requested', 'approval-responded', 'output-denied' states
  • Improve accessibility with aria-label and ARIA attributes
  • Replace 'any' types with proper SpeechRecognition types

@yinjiajun223
fix: add ExtendedToolState type for approval-related states
603c2af 
- Create shared types.ts for ExtendedToolState definition
- Fix TypeScript errors in ToolStatusBadge and Confirmation components
- Add type safety for 'approval-requested', 'approval-responded', 'output-denied' states
- Improve accessibility with aria-label and ARIA attributes
- Replace 'any' types with proper SpeechRecognition types
cwandev
cwandev approved these changes Dec 23, 2025
View reviewed changes
Copy link
Collaborator

@cwandev cwandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @yinjiajun223 🙏

@cwandev cwandev changed the title fix: add ExtendedToolState type for approval-related states fix: add shared ExtendedToolState for approval states Dec 23, 2025
@cwandev cwandev merged commit 3f5fbbc into vuepont:main Dec 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwandev cwandev cwandev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yinjiajun223 @cwandev