Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the generator to 7.20.0, which brings native Multipart-File uploading and therefore changes those functions. I'd love to not have those functions read from disk, but I cannot find a way to alter the file type function input in the templates at all.
(and I don't really want to spend another day writing a really complex replacement regex)
Edit: I reworked this again. It should now be similar to old versions (still with api breakages though)
I'm requesting a review from jelllejurre specifically, since he worked to add Multipart-File uploading too to rust. (#30)
This PR also generated and altered the templates (and knowledge of the templates) to apply some of the patches directly to those files directly.