allow setting an index URL when creating the venv#660
Open
chillinger wants to merge 3 commits intovoxpupuli:masterfrom
Open
allow setting an index URL when creating the venv#660chillinger wants to merge 3 commits intovoxpupuli:masterfrom
chillinger wants to merge 3 commits intovoxpupuli:masterfrom
Conversation
chillinger
force-pushed
the
venv_index
branch
3 times, most recently
from
29d79b6 to
b85d62a
Compare
kenyon
reviewed
May 17, 2023
Member
kenyon
left a comment
kenyon
left a comment
There was a problem hiding this comment.
Would be good to add a test that sets $index to something.
smortex
reviewed
May 22, 2023
manifests/pyvenv.pp
Outdated
|
|
||
| $index_config = $index ? { | ||
| undef => '', | ||
| default => "-i ${index}" |
Member
There was a problem hiding this comment.
Should we not shell_escape / batch_escape / powershell_escape this variable?
Author
|
Hi Team, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR provides an optional Parameter for the virtualenv creation. This allows e.g. in airgapped environments to specify a private pip index as source for the pip and setuptools packages
This Pull Request (PR) fixes the following issues