modulesync 10.3.0 #474
Merged
modulesync 10.3.0 #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
The requirement of the lint check ist fullfilled. Idempotency check is done by splat operator. Just in this very specific circumstance a static linter cannot not recognize its fullfillment. I propose to disable the check |
bastelfreak
reviewed
Dec 4, 2025
.github/workflows/ci.yml
Outdated
| uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v3 | ||
| uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v4 | ||
| with: | ||
| beaker_hypervisor: 'docker' |
Member
There was a problem hiding this comment.
as mentioned in https://github.com/voxpupuli/puppet-gitlab/pull/481/files/06f5f99680bc2cbb1b7556c60fcf0e63e0ca9974#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f, please fix the missing newline and cleanup the git history
Member
|
Please rebase against master to get rid of the merge commit and please adjust the title for 14acb75. That's way longer than 72 characters. |
In my opinion the requirement of the linter is satisfied. The code is idempotent. It is the parameter passing using the splat operator that enables idempotency. Puppet lint is a static validator that does not see the runtime fullfilment. It is ok to disable the check
due to some $magic between podman and sysctl, we will switch to docker for the pipeline to pass.
marcusdots
force-pushed
the
modulesync
branch
from
fd51557 to
959b732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulesync 10.3.0