Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 83.05% 83.24% +0.19%
==========================================
Files 11 11
Lines 1062 1086 +24
Branches 506 523 +17
==========================================
+ Hits 882 904 +22
Misses 6 6
- Partials 174 176 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Andeshog
reviewed
Jan 6, 2026
vortex_utils/src/math.cpp
Outdated
Comment on lines
178
to
179
| Eigen::Matrix3d R; | ||
| R << 0, 1, 0, 1, 0, 0, 0, 0, -1; |
Contributor
There was a problem hiding this comment.
To keep "constness" of R you could initialize it by calling a lambda ES.28. Also to make it more clear how the matrix is contstructed you could use column vectors
const Eigen::Matrix3d rotation_matrix_enu_to_ned = []{
Eigen::Matrix3d rotmat;
rotmat.col(0) = Eigen::Vector3d(0, 1, 0);
rotmat.col(1) = Eigen::Vector3d(1, 0, 0);
rotmat.col(2) = Eigen::Vector3d(0, 0, -1);
return rotmat;
}();
Andeshog
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.