Merged
Conversation
…or6d struct to vortex utils
…t each solver is more independent and will do perform own calculations
… factory class and descriptions for them
…s before. Will add tests whenever i find time again
… now), will clean up the code and fix warm start for next time
…ench in order to keep feasability and warm starting the solver after initializing
3 tasks
…s node tests fail :(
f792d80 to
a531809
Compare
kluge7
requested changes
Feb 2, 2026
…ubious and not testing the expected functionality. These are mostly tests for moments as sometimes the desired wrench and actual wrench will not physically be able to match given the constraints.
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
Andeshog
reviewed
Feb 5, 2026
the qp allocator and refactored some code because the node dies everytime i try to launch it and use it in the simulator
…unch, also muted CasADi prints in every iteration
jorgenfj
requested changes
Mar 7, 2026
Contributor
jorgenfj
left a comment
There was a problem hiding this comment.
Maybe move the "solvers" directory to src as that follows the standard ros package structure and maybe divide the headers into subfolders
Comment on lines
+57
to
+58
| public: | ||
| explicit ThrustAllocator(const rclcpp::NodeOptions &options); |
Contributor
There was a problem hiding this comment.
Maybe rename this class to ThrustAllocatorNode to make it more explicit that this is the ros class
Contributor
|
Maybe make solver type a launch arg instead of yaml param |
orca.yaml and added moby.yaml for testing in sim. Ran precommit hooks and checked codespell
update simulator-test.yml in order to fix failing test
…ile such that we can test both solver types in CI
…/vortex-auv into 580-task-Thrust-Allocator-AUV
jorgenfj
approved these changes
Mar 19, 2026
Contributor
jorgenfj
left a comment
There was a problem hiding this comment.
LGTM!
Maybe add simulator tests for both solvers. This way it is easier to pinpoint if one specific solver is the cause of potential failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the thrust allocator module to be easier to build upon. Added more documentation in the readme file and some basic unit testing of the thrust allocator functionality. Added a new solver using CasADi and Fossen's formulation of the QP thrust allocation problem. Whenever i find time again i will add more comprehensible unit testing.
Lastly it would be nice to have simulator testing and perform some analysis on computation time vs accuracy tradeoff for both pseudoinverse and the QP solver but that is outside of the scope of this PR.