simplify projection expression for SELECT * in duckdb#7885
Open
myrrc wants to merge 1 commit into
Open
Conversation
myrrc
added
changelog/feature
Signed-off-by: Mikhail Kot <to@myrrc.dev>
Merging this PR will degrade performance by 24.75%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | new_bp_prim_test_between[i16, 32768] |
120.6 µs | 134.6 µs | -10.36% |
| ❌ | Simulation | new_bp_prim_test_between[i32, 16384] |
95 µs | 109.4 µs | -13.12% |
| ❌ | Simulation | new_bp_prim_test_between[i32, 32768] |
141.4 µs | 170.2 µs | -16.96% |
| ❌ | Simulation | new_bp_prim_test_between[i64, 32768] |
178.5 µs | 237.2 µs | -24.75% |
| ❌ | Simulation | new_bp_prim_test_between[i64, 16384] |
115.6 µs | 144.9 µs | -20.23% |
| ❌ | Simulation | new_alp_prim_test_between[f64, 16384] |
127.2 µs | 149.1 µs | -14.66% |
Comparing myrrc/duckdb-star (3937337) with develop (93d0b4e)
| if column_id == FILE_ROW_NUMBER_COLUMN_IDX { | ||
| file_row_number_column_pos = Some(column_pos); | ||
| } | ||
| is_star &= column_id == real_column_count; |
| let mut real_column_count = 0; | ||
|
|
||
| for (column_pos, &column_id) in ids.iter().enumerate() { | ||
| #[expect(clippy::cast_possible_truncation)] |
|
|
||
| pub fn projection_ids(&self) -> Option<&[u64]> { | ||
| if self.input.projection_ids.is_null() { | ||
| if self.input.projection_ids.is_null() || self.input.projection_ids_count == 0 { |
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
no clippy allow please
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
can you also please explain this logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case we have a SELECT * with possible virtual columns, use
root() and not select(names, root()) in duckdb