Skip to content

Faster Mask::from_slices#7857

Merged
gatesn merged 1 commit intodevelopfrom
ngates/faster-from-slices
May 9, 2026
Merged

Faster Mask::from_slices#7857
gatesn merged 1 commit intodevelopfrom
ngates/faster-from-slices

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented May 9, 2026

Do not iterate individual bits to construct a mask from slices

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/performance A performance improvement label May 9, 2026
@gatesn gatesn marked this pull request as ready for review May 9, 2026 19:28
@gatesn gatesn enabled auto-merge (squash) May 9, 2026 19:28
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 9, 2026

Merging this PR will improve performance by 12.92%

⚡ 2 improved benchmarks
✅ 1170 untouched benchmarks
⏩ 36 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.5)] 1,111.5 µs 984.4 µs +12.92%
Simulation take_map[(0.1, 1.0)] 1.8 ms 1.6 ms +11.37%

Comparing ngates/faster-from-slices (2ea9600) with develop (ff12040)

Open in CodSpeed

Footnotes

  1. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn merged commit 96dbb87 into develop May 9, 2026
62 of 67 checks passed
@gatesn gatesn deleted the ngates/faster-from-slices branch May 9, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants