Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will improve performance by 12.74%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | take_map[(0.1, 0.5)] |
1,111.5 µs | 985.9 µs | +12.74% |
| ⚡ | Simulation | take_map[(0.1, 1.0)] |
1.8 ms | 1.6 ms | +11.49% |
Comparing ngates/stats-expr (ec42e75) with develop (ff12040)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the epic #7707
This PR adds an expression that returns the requested statistic, blown out for each row. When run against a single array, this returns a ConstantArray. When run against ChunkedArray, it returns RunEnd stats.
It will be used by pluggable Falsify/Verify rewrite rules to allow for the workflow of adding custom aggregate functions to zone maps for falsification checks, e.g. bloom filters.