Open
Conversation
Contributor
|
You might want to rebase, and then you can get local previews using |
connortsui20
force-pushed
the
ct/template
branch
2 times, most recently
from
d0ece9c to
d4cb849
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/ext-types
branch
from
4cee32e to
21c6e6e
Compare
Contributor
Author
|
I noticed that both footnotes and syntax highlighting seem to not be supported. Edit: Syntax highlighting PR #17 |
gatesn
requested changes
Feb 28, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
I'm not sure what this RFC is proposing...
I think what is being proposed already exists on develop, and the unresolved questions remain unresolved?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
This RFC proposes extending the
ExtVTabletrait to support richer behavior for extension types beyond forwarding to the storage type.It covers the already completed vtable infrastructure, the proposed trait design for types/scalars/arrays, and identifies open questions around the extension array API and compute dispatch.
The big open question here is if we need to do this at all. And if we do need to do this, what should the extension array API look like? Importantly, how should we define expressions over extension type arrays?