Skip to content

ci: bump to v1.5.3; Windows build deferred pending upstream vortex port #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joseph-isaacs wants to merge 7 commits into
base: main
Choose a base branch
from
+8 −164
Open

ci: bump to v1.5.3; Windows build deferred pending upstream vortex port #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a145953
ci: enable Windows (windows_amd64) build
claude Jun 1, 2026
d5d47cf
ci: build all Windows variants (amd64, arm64, mingw, rtools)
claude Jun 1, 2026
a0444c1
ci: use MSVC /W4 instead of dropping warnings on Windows
claude Jun 1, 2026
81ccb88
ci: limit Windows builds to MSVC amd64 and arm64
claude Jun 1, 2026
65788e8
ci: remove leftover extension-template self-test workflow
claude Jun 1, 2026
d014fee
ci: drop fragile windows_arm64 build
joseph-isaacs Jun 1, 2026
78d8545
ci: park Windows build (defer pending upstream vortex Windows port)
joseph-isaacs Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 0 additions & 162 deletions .github/workflows/ExtensionTemplate.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/MainDistributionPipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
ci_tools_version: v1.5.3
duckdb_version: v1.5.3
extension_name: vortex
exclude_archs: "wasm_mvp;wasm_eh;wasm_threads;windows_amd64_rtools;windows_amd64_mingw;windows_amd64;linux_amd64_musl"
exclude_archs: "wasm_mvp;wasm_eh;wasm_threads;windows_amd64;windows_amd64_mingw;windows_amd64_rtools;windows_arm64;linux_amd64_musl"
extra_toolchains: "rust"
8 changes: 7 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ set(LOADABLE_EXTENSION_NAME ${TARGET_NAME}_loadable_extension)
build_static_extension(${TARGET_NAME} src/vortex_extension.cpp)
build_loadable_extension(${TARGET_NAME} "" src/vortex_extension.cpp)

set(VORTEX_WARNING_FLAGS -Wall -Wextra -Wpedantic)
# MSVC's `cl` does not understand the GCC/Clang warning flags, so use the
Copy link
Copy Markdown
Contributor

@0ax1 0ax1 Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting in the comment that MSVC is set even for clang builds by CMake.

# equivalent high warning level there instead of dropping warnings entirely.
if(MSVC)
Copy link
Copy Markdown
Contributor

@0ax1 0ax1 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I build on Windows with clang? Ideally, we would also build with Clang on Windows, using the same compiler flags.

set(VORTEX_WARNING_FLAGS /W4)
Copy link
Copy Markdown
Contributor

@0ax1 0ax1 Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clean up the PR title and description here?

else()
set(VORTEX_WARNING_FLAGS -Wall -Wextra -Wpedantic)
endif()

target_compile_options(${EXTENSION_NAME} PRIVATE ${VORTEX_WARNING_FLAGS})
target_link_libraries(${EXTENSION_NAME}
Expand Down
Loading