fix(redo): wait for queue manager before recovery, prevent silent task loss#1237
Open
yc111233 wants to merge 1 commit intovolcengine:mainfrom
Open
fix(redo): wait for queue manager before recovery, prevent silent task loss#1237yc111233 wants to merge 1 commit intovolcengine:mainfrom
yc111233 wants to merge 1 commit intovolcengine:mainfrom
Conversation
…task loss Three issues in _recover_pending_redo / _enqueue_semantic: 1. Redo recovery runs immediately at start() but the queue manager may not be initialized yet. _enqueue_semantic silently returns when queue_manager is None, then mark_done removes the redo marker → the task is permanently lost and memories are never extracted. 2. The VLM timeout during recovery is 60 s. If VLM is unavailable, each redo task wastes a full minute, and with multiple tasks this delays service readiness by several minutes. 3. _enqueue_semantic silently drops work when queue_manager is None. Any caller that assumes the work was accepted will proceed and delete its redo marker, losing the task. Fixes: - Wait up to 30 s for queue manager to become available before starting redo recovery; if it never appears, defer to next restart. - Reduce VLM timeout during recovery from 60 s to 15 s. - Make _enqueue_semantic raise RuntimeError instead of silently returning when queue_manager is None so callers cannot accidentally mark the task as done. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start()but the queue manager may not be initialized yet._enqueue_semanticsilently returns whenqueue_manager is None, thenmark_doneremoves the redo marker — the task is permanently lost and memories are never extracted.Root cause
Three issues compound:
_recover_pending_redostarts before queue manager is ready_enqueue_semanticsilently drops work whenqueue_manager is Nonemark_doneruns after the silent drop → redo marker deleted → task lost foreverLog evidence:
Fix
_enqueue_semanticraiseRuntimeErrorinstead of silently returning when queue_manager isNoneTest plan
🤖 Generated with Claude Code