Skip to content

fix(create): skip monorepo editor configs by default#1729

Merged
fengmk2 merged 3 commits into
voidzero-dev:mainfrom
jong-kyung:fix/monorepo-editor-config-create
Jun 1, 2026
Merged

fix(create): skip monorepo editor configs by default#1729
fengmk2 merged 3 commits into
voidzero-dev:mainfrom
jong-kyung:fix/monorepo-editor-config-create

Conversation

@jong-kyung
Copy link
Copy Markdown
Collaborator

Summary

Fixes #866.

vp create no longer auto-prompts for editor configuration or writes package-local editor settings when creating a project inside an existing monorepo. Monorepo packages now stay editor-agnostic by default, while explicit --editor remains an opt-in for users who intentionally want package-local settings.

Changes

  • Skips automatic editor detection/selection when vp create runs inside an existing monorepo without --editor.
  • Keeps --editor <name> as an explicit opt-in, including inside monorepos.
  • Keeps --no-editor as an explicit opt-out.
  • Normalizes repeated or mixed editor flags so values like --editor vscode --editor zed or --no-editor --editor vscode do not leak unexpected array values into create flow logic.
  • Preserves existing behavior for standalone project creation and newly created monorepo roots.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 1, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit b06bd4c
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a1ce84c2fbc61000848a5e6

@jong-kyung
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jong-kyung jong-kyung self-assigned this Jun 1, 2026
@jong-kyung jong-kyung marked this pull request as ready for review June 1, 2026 02:02
@jong-kyung jong-kyung requested a review from fengmk2 June 1, 2026 02:02
@fengmk2 fengmk2 merged commit 7501b30 into voidzero-dev:main Jun 1, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable VSCode settings generation in monorepo mode

2 participants