fix(create): keep aliased vite in pnpm monorepo website so override stays effective

[fengmk2]

Summary

In a monorepo created via vp create vite:monorepo with pnpm, running vp why vite reported the override as ineffective: it resolved vite to upstream vite (a transitive dependency of @voidzero-dev/vite-plus-core) rather than to @voidzero-dev/vite-plus-core itself.

Root cause

PR #1697 added dropAliasedRuntimeDevDeps, which strips vite/vitest from apps/website/package.json for every package manager. For pnpm this removed the only direct vite dependency in a fresh workspace, so the pnpm-workspace.yaml overrides.vite: catalog: entry had no consumer to redirect. The only vite left in the tree was vite-plus-core's own internal vite, so vp why vite showed upstream vite and the override looked ineffective. The single-package app keeps vite: catalog: and resolves correctly.

npm / yarn / bun: confirmed not affected (no fix needed)

I verified their override is effective in both single-app and monorepo: node_modules/vite resolves to @voidzero-dev/vite-plus-core, and <pm> why @voidzero-dev/vite-plus-core shows it redirecting even vite-plus-test's peer vite. Their root overrides/resolutions redirect the transitive/peer vite regardless of a direct dependency. Their vp why vite display gap is a pre-existing limitation of npm explain / yarn why / bun why (they query by resolved package name, not the vite alias key), identical with or without the monorepo strip, so it is out of scope here.

Fix

dropAliasedRuntimeDevDeps now returns early for pnpm, keeping the aliased vite/vitest so the workspace override has a direct consumer. npm/yarn/bun keep stripping the dead-weight keys.

Before / after (vp why vite in a fresh pnpm monorepo)

Before:

vite@8.0.14
└─┬ @voidzero-dev/vite-plus-test@0.1.23
  └─┬ vite-plus@0.1.23
    ...
Found 1 version of vite

After:

@voidzero-dev/vite-plus-core@0.1.23
├─┬ @voidzero-dev/vite-plus-test@0.1.23
│ └─┬ vite-plus@0.1.23
│   └── website@0.0.0 (devDependencies)
...

Verification

• New unit test packages/cli/src/create/__tests__/monorepo.spec.ts: failed for pnpm before the fix (vite stripped), now passes 4/4 (pnpm keeps, npm/yarn/bun drop).
• Create + migration unit suite: 234/234 pass; lint clean.
• End-to-end against a rebuilt global CLI: real vp create vite:monorepo + vp why vite now resolves to @voidzero-dev/vite-plus-core.
• Global snap test new-vite-monorepo regenerated (website now keeps vite: catalog:); new-vite-monorepo-bun unchanged.
• CI test-vp-create.yml assertion made pnpm-aware: pnpm must keep vite; npm/yarn/bun must drop vite/vitest.

---

Note

Low Risk
Scoped to monorepo scaffold post-processing and documentation; behavior change is intentional and covered by unit, snap, and CI checks.

Overview
pnpm monorepo create no longer strips aliased vite/vitest from apps/website/package.json. The logic moves into exported dropAliasedRuntimeDevDeps, which returns early for pnpm so workspace overrides still have a direct vite consumer (fixing misleading vp why vite after vp create vite:monorepo). npm, yarn, and bun still remove those keys after migration.

Migration guidance is updated in docs/guide/migrate.md, vp migrate help, and snap tests to say: on pnpm, keep migrator-aliased vite/vitest; on other package managers, remove them after import rewrites.

CI (test-vp-create.yml) now asserts pnpm keeps vite on the website app while other PMs must not. New monorepo.spec.ts covers pnpm vs npm/yarn/bun behavior; new-vite-monorepo snap expects vite: catalog: on the website.

^{Reviewed by Cursor Bugbot for commit 16f7d45. Configure here.}

[netlify]

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	45dfe4c
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a1d297f7b986f0008157df5

[github-actions]

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: 45dfe4c

[fengmk2]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 16f7d45. Configure here.}