Skip to content

fix(cli): remove windows current link without rmdir#1726

Merged
fengmk2 merged 1 commit into
mainfrom
fix/windows-install-current-link
Jun 1, 2026
Merged

fix(cli): remove windows current link without rmdir#1726
fengmk2 merged 1 commit into
mainfrom
fix/windows-install-current-link

Conversation

@TheAlexLichter
Copy link
Copy Markdown
Member

I've hit a powershell issue while installing Vite+ after it hang in the git bash:

cmd : The directory is not empty.
  At line:589 char:9
  +         cmd /c rmdir "$CurrentLink" 2>$null
  +         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      + CategoryInfo          : NotSpecified: (The directory is not empty.:String) [], RemoteException
      + FullyQualifiedErrorId : NativeCommandError

To fix this, the installer now removes the existing current via Powershell logic and detects junctions or symlinks, as well as handling stale directories.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 31, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 1b242e9
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a1c80096735e60008c22501

@github-actions
Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: 1b242e9

Copy link
Copy Markdown
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengmk2 fengmk2 merged commit e3315d0 into main Jun 1, 2026
54 checks passed
@fengmk2 fengmk2 deleted the fix/windows-install-current-link branch June 1, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants