Skip to content

fix(cli): remove global why flag#1720

Merged
fengmk2 merged 6 commits into
voidzero-dev:mainfrom
liangmiQwQ:codex/remove-why-global
May 31, 2026
Merged

fix(cli): remove global why flag#1720
fengmk2 merged 6 commits into
voidzero-dev:mainfrom
liangmiQwQ:codex/remove-why-global

Conversation

@liangmiQwQ
Copy link
Copy Markdown
Contributor

Close #1656

The current vp why -g behavior delegates to the underlying package manager global mode, which does not inspect Vite+-managed global packages.

This PR removes the -g/--global option from vp why, keeps vp why project-scoped, and updates the global CLI help snapshot. vp outdated -g remains handled by the Vite+-managed global package flow.

🤖 Generated with Codex

@netlify
Copy link
Copy Markdown

netlify Bot commented May 30, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 4ec308b
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a1b95fe6abc5900085a055c

@liangmiQwQ liangmiQwQ marked this pull request as ready for review May 30, 2026 14:43
@liangmiQwQ
Copy link
Copy Markdown
Contributor Author

Should it be a breaking change?

@liangmiQwQ
Copy link
Copy Markdown
Contributor Author

@codex

@liangmiQwQ liangmiQwQ changed the title fix(cli): remove global why flag fix(cli)!: remove global why flag May 30, 2026
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented May 30, 2026

Should it be a breaking change?

This command has never worked, so it probably doesn't count. 😄

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 798687b430

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_pm_cli/src/cli.rs
@liangmiQwQ liangmiQwQ changed the title fix(cli)!: remove global why flag fix(cli): remove global why flag May 30, 2026
@liangmiQwQ liangmiQwQ marked this pull request as draft May 30, 2026 14:49
@liangmiQwQ liangmiQwQ marked this pull request as ready for review May 30, 2026 14:51
@fengmk2 fengmk2 merged commit d64f82f into voidzero-dev:main May 31, 2026
62 of 64 checks passed
@liangmiQwQ liangmiQwQ deleted the codex/remove-why-global branch May 31, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp why -g and vp outdated -g should check global packages managed by Vite+

2 participants