Context support with Tests#508
Closed
hartsock wants to merge 3 commits intovmware:masterfrom
Closed
Conversation
added 3 commits
February 6, 2017 14:08
Includes tests fixtures for Context support in pyVmomi. Also accounts for nested and reused contexts in a single python script. Additional work checks session keys on the server to make sure orphaned sessions do not hang around and cause a memory leak.
tianhao64
reviewed
Feb 13, 2017
| return | ||
|
|
||
|
|
||
| def open(host='localhost', port=443, user='root', pwd='', |
Contributor
There was a problem hiding this comment.
It seems open and close functions are similar as Connect/Disconnect in connect.py beside SetSi(). I wonder if it's better to add these two methods in connect.py so we could reuse the existing logic?
Contributor
|
This has been open for almost two years. It should be moved forward or closed. |
Contributor
Author
|
Closing — this PR is over 8 years old and the project has moved on. Thank you for the original review feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a branch with nested Python Context support. I found this helpful in designing larger projects where I did not want to leave dangling sessions on the vSphere/vCenter/ESXi host that could constitute a memory leak.