feat: migrate to v1.0.0 for package manager compliance (atomic Go module migration)#59
Closed
vxfemboy wants to merge 270 commits intovmfunc:mainfrom
Closed
feat: migrate to v1.0.0 for package manager compliance (atomic Go module migration)#59vxfemboy wants to merge 270 commits intovmfunc:mainfrom
vxfemboy wants to merge 270 commits intovmfunc:mainfrom
Conversation
TODO: build go application
when not choosing small/medium/large
solves the issue with nil Disallow values
- Update README.md contributor links (lunchcat → vmfunc) - Update Makefile repo URL, remove lunchcat.dev - Update .all-contributorsrc projectOwner - Add comprehensive CHANGELOG.md - Standardize Discord links to discord.com/invite/sifcli Enables package manager compliance for Void Linux, Debian, Fedora, Arch. Part 8/8 of v1.0.0 migration - COMPLETE. Closes vmfunc#57 Related: vmfunc#50
dbb598f to
2566459
Compare
Author
Infrastructure preparation for builtin complex Go module registration.
Converted nuclei scan to be able to run as module.
Fixed nil pointer dereference issues in the nuclei scan running as a module
Set the HostErrorsCache executor option, cache is created but not passed as option. Headless initialization is required even without browser templates. Nuclei expects project file to be set
Fixed Nuclei giving off exception for missing Colorizer on the executor options.
Renamed the nuclei module file to differentiate from the nuclei legacy scan file.
feat(modules): builtin nuclei scan as module
Owner
Author
|
@vmfunc resolved |
vmfunc
requested changes
Jan 30, 2026
vmfunc
requested changes
Feb 13, 2026
Owner
vmfunc
left a comment
There was a problem hiding this comment.
hey, thanks for pushing on this - the module path migration is needed and the approach is right (atomic, single PR). couple things though:
build-breaking issues:
sif.goremoves theinternal/scan/builtinimport but still callsbuiltin.Register()on two lines - that won't compile- the entire
internal/scan/builtin/package (5 files) still hasdropalldatabasesimports and isn't touched by this PR at all -register.go,shodan_module.go,whois_module.go,frameworks_module.go,nuclei_module.goall need the import swap
missed files:
.github/workflows/release.yml- hasgo install github.com/dropalldatabases/sif/cmd/sif@v....golangci.yml- hasgithub.com/dropalldatabases/sif/internal/logger.Writein the errcheck exclude
also needs a rebase - main has diverged significantly (new lint config, dependency bumps, CI changes). that's probably why CI is failing on top of the missing files.
the CHANGELOG is nice but pretty heavy for this project's style - we haven't maintained one before and i'd rather not start now. the release notes on the tag are enough. would prefer to drop that file from this PR.
once the builtin package + those config files are updated and it's rebased, this should be good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I understand the preference for PRs with ≤5 files modified. However, this Go module path migration must be atomic to prevent CI failures and build breakage.
Technical Constraint: Go Module Migration Must Be Atomic
When changing a Go module path in
go.mod, all import statements across the entire codebase must be updated simultaneously in the same commit/PR. Here's why:If split into multiple PRs:
go.mod→ All subsequent PRs fail CI (can't import old path)The only working approach: Change
go.mod+ all imports in a single atomic PR.What We're Doing About the File Count
To minimize impact, we're splitting independent changes into separate PRs:
Makefile,.all-contributorsrc,README.mdcontributor linksCONTRIBUTING.md,docs/README.mdThis PR only contains the atomic Go module migration that cannot be split without breaking the build.