refactor(rsc): remove server optimizeDeps.include in favor of cjs module runner transform

[hi-ogawa]

Description

• closes Dependency resolution fails in pnpm monorepo when nodeLinker is not hoisted #789

After #687, this should work in principle. If not, we should improve cjs module runner transform.

TODO

• it looks like we are missing default import interop fix(rsc): fix cjs default import on module runner #695
• test-provider-in-server-dep in packages/plugin-rsc/examples/basic/src/routes/deps/client-in-server/server.tsx is broken. it looks like dual module of @vitejs/test-dep-client-in-server2/client.
  • hmm, it looks like this is because nothing is optimized on server and ?v= won't be added to anymore, which breaks client-in-server-package-proxy detection logic.
  • we should check Vite's isInNodeModule instead of ?v= fix(rsc): replace ?v= check with more robust node_modules detection #696
• make it a separate plugin package?

[hi-ogawa]

We should try ecosystem ci (Waku and react-router). If it's fine, we should go forward.

[hi-ogawa]

One concern is we might want this with enforce: "pre" so that other plugin won't see require.

[hi-ogawa]

Cloudflare plugin tries to optimize everything by default and it seems to cause an issue. To prevent this, users now need optimizeDeps.exclude: ["react", "react-dom"], which feels like somewhat killing the purpose of this PR.

[hi-ogawa]

This is unfortunate, but necessary anyways since react 3rd party libraries with potential "use client" cannot be optimized.

[silvenon]

Hello, I was looking for an issue/PR to track that causes my CJS module to fail during development. This is it, right?

Repro: https://github.com/silvenon/repro/tree/vite-rsc-ssr-no-external

# with GitHub CLI
gh repo clone silvenon/repro -b vite-rsc-ssr-no-external
cd repro
corepack install
pnpm install
pnpm run dev --open # fails ❌
pnpm run build
pnpm run preview --open # works ✅

At the time of creating the repro it didn't cross my mind that this could be related to CJS. But I also think that the way the problematic module is authored is faulty in its attempt at dual publish.

[hi-ogawa]

@silvenon Can you open an issue? This PR is a pure internal refactor and I cannot tell the direct relation. From a quick look, you have Vite beta 8 override, so is it possible that's another factor? (I've heard there are a few cjs related change due to rolldown)

[silvenon]

Done, opened #1072 👍