fix(plugin-rsc): preserve source maps in transform and renderChunk hooks #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed four plugin hooks that were breaking source maps by modifying code
without returning proper source maps:
- rsc:vite-client-raw-import (transform)
- rsc:virtual:vite-rsc/assets-manifest (renderChunk)
- rsc:inject-async-local-storage (transform)
- rsc:encryption-key (renderChunk)
All hooks now use MagicString to perform code transformations and return
both code and map with generateMap({ hires: "boundary" }). Transform hooks
include source, id, and includeContent in the map generation.
https://claude.ai/code/session_017TyWqNZcteH84BkF2BGMZx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed four plugin hooks that were breaking source maps by modifying code without returning proper source maps:
All hooks now use MagicString to perform code transformations and return both code and map with generateMap({ hires: "boundary" }). Transform hooks include source, id, and includeContent in the map generation.
https://claude.ai/code/session_017TyWqNZcteH84BkF2BGMZx