Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Rolldown DevTools package’s identifiers and log prefixes from vite-devtools to rolldown-devtools, aligning naming across the Rolldown integration.
Changes:
- Rename the websocket event name constant to
rolldown-devtools. - Update console log prefixes to
[rolldown-devtools]in Node + app RPC/JSON parsing utilities. - Change the persisted client settings localStorage key to
rolldown-devtools-settings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rolldown/src/shared/constants.ts | Updates the WS event name constant string. |
| packages/rolldown/src/node/utils/json-parse-stream.ts | Updates warning log prefix for skipped JSON lines. |
| packages/rolldown/src/modules/rpc.ts | Renames the Vite plugin name identifier for the Nuxt module integration. |
| packages/rolldown/src/app/state/settings.ts | Changes the localStorage key used to persist client settings. |
| packages/rolldown/src/app/composables/rpc.ts | Updates RPC error log prefixes in the client. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.