feat: add sortable column headers to all job list tables#24
Merged
Conversation
Add clickable column headers for sorting across all job tables: - Ready Jobs: class_name, queue_name, priority, created_at - Scheduled Jobs: class_name, queue_name, scheduled_at - Failed Jobs: class_name, queue_name, created_at - In Progress Jobs: class_name, queue_name, created_at - Recurring Jobs: key, class_name, queue_name, priority - Jobs: class_name, queue_name, status, created_at - Queues: queue_name, job_count - Workers: hostname, last_heartbeat_at Features: - Click to sort ascending, click again for descending - Visual indicators: ↑ (asc), ↓ (desc), ⇅ (default/sortable) - Sort state preserved across pagination and filtering - Special handling for execution tables with JOIN queries - Special handling for GROUP BY queries on queues page Includes comprehensive test coverage with 27 new specs.
ca8c005 to
2dcb72b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tables with Sorting
Implementation
BaseControllerwithsort_params,apply_sorting, andapply_execution_sortingmethodssortable_headerhelper toBasePresenterfor generating clickable header linksTest Plan