Examples: Update filter example to maplibre#2386
Open
tordans wants to merge 4 commits intovisgl:masterfrom
Open
Examples: Update filter example to maplibre#2386tordans wants to merge 4 commits intovisgl:masterfrom
tordans wants to merge 4 commits intovisgl:masterfrom
Conversation
tordans
changed the title
Collaborator
|
@tordans Do you mind rebase this to target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the filter example to maplibre and removes the notes on mapbox.
I was actually testing something else and this was a by product.
Let me know if this would be useful and what would have to change.
The example itself is not as good as before because it always only highlights one state. But moving to the maplibre state example dataset was the quickest way to get this working again. It would be more ideal to have the mapbox dataset as open data as an example but I did not check that.