Skip to content

Fix Rust PyPI trusted publishing permission #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinitkumar merged 1 commit into from
Jun 5, 2026
Merged

Fix Rust PyPI trusted publishing permission #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-rust-wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ env:

permissions:
contents: read
id-token: write
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider scoping id-token: write to the specific job that requires it rather than at the workflow level.

This makes OIDC tokens available to every job. To follow least-privilege, only enable id-token: write in the permissions block of the specific jobs that actually need it, keeping the workflow-wide permissions minimal.

Suggested implementation:

permissions:
  contents: read

jobs:
  # Build wheels for Linux

To fully implement least-privilege, add a permissions block to the specific job(s) that actually require OIDC, for example:

jobs:
  some-job-that-needs-oidc:
    permissions:
      id-token: write
      contents: read
    steps:
      ...

Adjust the job name and permissions according to the actual job in this workflow that uses OIDC (e.g. for cloud auth/deploy). Other jobs should omit id-token: write.


jobs:
# Build wheels for Linux
Expand Down
Loading