Don't set cpo&vim if we're going to early exit#399
Merged
alerque merged 2 commits intovim-pandoc:masterfrom Apr 18, 2025
Merged
Don't set cpo&vim if we're going to early exit#399alerque merged 2 commits intovim-pandoc:masterfrom
set cpo&vim if we're going to early exit#399alerque merged 2 commits intovim-pandoc:masterfrom
Conversation
This was a bad merge that resulted from vim-pandoc#393 being opened before vim-pandoc#397 but landing after. If we override the `&cpo` option and then `finish`, it will never get set back to the saved cpo. Instead, let's just only do the `set` if we're sure we're not going to early exit.
This also regressed in vim-pandoc#393, but we may as well fix it here.
jez
commented
Apr 17, 2025
Member
|
Good catch, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bad merge that resulted from #393 being opened before #397
but landing after.
If we override the
&cpooption and thenfinish, it will never getset back to the saved cpo.
Instead, let's just only do the
setif we're sure we're not going toearly exit.