Open
Conversation
typo `latitudePrecission` -> `latitudePrecision` return value doesn't need to be `VARCHAR(MAX)`, since max digits is 15 and doesn't include the `+`, we should be using `16` `VARCHAR(MAX)` -> `VARCHAR(16)` clarity for order of operations `POWER(@EncodingBase, @codelength / -2 + 2)` - > `POWER(@EncodingBase, (@codelength / -2) + 2)` Not changed: Should we range-check `@codeLength` for a _maximum_ value? It could mess up the precision calculations in the latitude = 90 logic around line 46.
| @@ -44,9 +44,9 @@ BEGIN | |||
| IF (@latitude = @LatitudeMax) | |||
| BEGIN | |||
| DECLARE @latitudePrecission DECIMAL(9,6); | |||
Owner
There was a problem hiding this comment.
Thanks for the improvements! And for pointing out the typo. Please change it also here on line 46 so I can merge your pull request. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typo
latitudePrecission->latitudePrecisionreturn value doesn't need to be
VARCHAR(MAX), since max digits is 15 and doesn't include the+, we should be using16VARCHAR(MAX)->VARCHAR(16)clarity for order of operations
POWER(@EncodingBase, @codeLength / -2 + 2)- >POWER(@EncodingBase, (@codeLength / -2) + 2)Not changed:
Should we range-check
@codeLengthfor a maximum value? It could mess up the precision calculations in the latitude = 90 logic around line 46.