Skip to content

Dialog: Fix wrong CSEQ on ACK for re-INVITE #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmillan merged 1 commit into from
Mar 10, 2026
Merged

Dialog: Fix wrong CSEQ on ACK for re-INVITE #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

### NEXT

### 3.13.6

- Dialog: Fix wrong CSEQ on ACK for re-INVITE (#966). Thans to @sabrineLayouni reporting.

### 3.13.5

- ReferSubscriber: Fix authentication causing ID update (#961). Thans to @sabrineLayouni reporting.
Expand Down
22 changes: 11 additions & 11 deletions src/Dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ module.exports = class Dialog {
this._remote_uri = message.parseHeader('from').uri;
this._remote_target = contact.uri;
this._route_set = message.getHeaders('record-route');
this.incoming_ack_seqnum = message.cseq;
this.outgoing_ack_seqnum = null;
this._incoming_ack_seqnum = message.cseq;
this._outgoing_ack_seqnum = null;
}
// RFC 3261 12.1.2.
else if (type === 'UAC') {
Expand All @@ -75,8 +75,8 @@ module.exports = class Dialog {
this._remote_uri = message.parseHeader('to').uri;
this._remote_target = contact.uri;
this._route_set = message.getHeaders('record-route').reverse();
this.incoming_ack_seqnum = null;
this.outgoing_ack_seqnum = this._local_seqnum;
this._incoming_ack_seqnum = null;
this._outgoing_ack_seqnum = this._local_seqnum;
}

this._ua.newDialog(this);
Expand Down Expand Up @@ -175,12 +175,12 @@ module.exports = class Dialog {
}

// ACK received. Cleanup this._ack_seqnum.
if (request.method === JsSIP_C.ACK && this.incoming_ack_seqnum !== null) {
this.incoming_ack_seqnum = null;
if (request.method === JsSIP_C.ACK && this._incoming_ack_seqnum !== null) {
this._incoming_ack_seqnum = null;
}
// INVITE received. Set this._ack_seqnum.
else if (request.method === JsSIP_C.INVITE) {
this.incoming_ack_seqnum = request.cseq;
this._incoming_ack_seqnum = request.cseq;
}

this._owner.receiveRequest(request);
Expand All @@ -197,12 +197,12 @@ module.exports = class Dialog {
// CANCEL and ACK must use the same sequence number as the INVITE.
const cseq =
method === JsSIP_C.CANCEL || method === JsSIP_C.ACK
? this.outgoing_ack_seqnum
? this._outgoing_ack_seqnum
: (this._local_seqnum += 1);

// In case of re-INVITE store ack_seqnum for future CANCEL or ACK.
if (method === JsSIP_C.INVITE) {
this.outgoing_ack_seqnum = cseq;
this._outgoing_ack_seqnum = cseq;
}

const request = new SIPMessage.OutgoingRequest(
Expand Down Expand Up @@ -234,8 +234,8 @@ module.exports = class Dialog {
// We are not expecting any ACK with lower seqnum than the current one.
// Or this is not the ACK we are waiting for.
if (
this.incoming_ack_seqnum === null ||
request.cseq !== this.incoming_ack_seqnum
this._incoming_ack_seqnum === null ||
request.cseq !== this._incoming_ack_seqnum
) {
return false;
}
Expand Down