chore(deps[libvcs]): track vcs_gitconfig fixture rename#548
Open
chore(deps[libvcs]): track vcs_gitconfig fixture rename#548
Conversation
why: libvcs#528 renames the pytest plugin's `gitconfig`/`hgconfig` fixtures to `vcs_gitconfig`/`vcs_hgconfig` so they no longer collide with the third-party pytest-gitconfig plugin. vcspull's three call sites (autouse setup() in conftest, two tests in test_fixtures) update to the new parameter name. The libvcs branch is tracked via [tool.uv.sources] until libvcs 0.41.0 ships on PyPI. what: - Update `gitconfig` -> `vcs_gitconfig` in conftest.py:setup() - Update `gitconfig` -> `vcs_gitconfig` in tests/test_fixtures.py (test_home_contains_gitconfig and the embedded conftest text inside test_pytester_git_commit_in_isolated_run) - Bump libvcs constraint to >=0.41.0,<0.42.0 - Add [tool.uv.sources] tracking the libvcs deconflict-with- pytest-gitconfig branch until 0.41.0 lands; drop after release - Refresh uv.lock to pin to the libvcs branch commit - CHANGES entry under v1.60.x
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 29 29
Lines 4114 4114
Branches 813 813
=======================================
Hits 3440 3440
Misses 440 440
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
why: libvcs branch advanced one commit to add the MIGRATION note (libvcs#529, commit 8f82783). Keep vcspull's lockfile pinned to the current libvcs branch tip so reviewers see both PRs against matching state. what: - uv lock --upgrade-package libvcs: 74dbbaeb -> 8f827837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracks libvcs's pytest plugin fixture rename (libvcs#528 / libvcs#529).
libvcs renames its
gitconfig/hgconfig/set_gitconfig/set_hgconfigpytest fixtures tovcs_gitconfig/vcs_hgconfig/set_vcs_gitconfig/set_vcs_hgconfigto vacate the namespace that collided with the third-partypytest-gitconfigplugin. vcspull only references one of these fixtures (gitconfig, in three places), so the test-side change is small.Changes
conftest.py:setup()— autouse fixture now requestsvcs_gitconfigtests/test_fixtures.py::test_home_contains_gitconfig— parameter renametests/test_fixtures.py::test_pytester_git_commit_in_isolated_run— embedded conftest text updates the parameter name in the spawned pytester runpyproject.toml— bumplibvcsconstraint to>=0.41.0,<0.42.0pyproject.toml— add[tool.uv.sources]tracking the libvcs branch until 0.41.0 ships on PyPI; drop this section in a follow-up after libvcs 0.41.0 releaseuv.lock— refresh, pins to libvcs branch commit74dbbaeCHANGES— Development entry under v1.60.xTest plan
uv lock— resolved 92 packages, libvcs pinned to branch commituv sync --all-extras— cleanuv run ruff format ./uv run ruff check .— all checks passeduv run mypy— no issues found in 86 source filesuv run pytest— 1028 passed (with 27 syrupy snapshots)Follow-up
Once libvcs 0.41.0 ships on PyPI, open a follow-up PR removing the
[tool.uv.sources]block — the version constraint alone will then resolve correctly from PyPI.