Add Application's health check#552
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sector2000 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @sector2000. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
99cef50 to
b6f8c2a
Compare
b6f8c2a to
159263b
Compare
159263b to
1c8718d
Compare
|
/ok-to-test |
The health check for
Applicationresources has been removed inArgoCDsince1.8. See here for more details. Nevertheless it is required when using theapp-of-appspatterns and you want to use sync waves among the apps to ensure they are deployed in the proper order, especially during the bootstrap phase.The downside is that, if one of the children apps is degraded, the whole
app-of-appsbecomes degraded, and in some cases this might not be desired. For this reason I made the health check optional via thegitops.applicationHealthCheckEnabledparameter of thepatterns-operator-configConfigMap, and by default it is disabled, for backward compatibility.