Drop special cased eso overrides now that eso 1.1 exists for ocp 4.18 onwards#590
Open
mbaldessari wants to merge 1 commit intovalidatedpatterns:mainfrom
Open
Drop special cased eso overrides now that eso 1.1 exists for ocp 4.18 onwards#590mbaldessari wants to merge 1 commit intovalidatedpatterns:mainfrom
mbaldessari wants to merge 1 commit intovalidatedpatterns:mainfrom
Conversation
… onwards Tested on mcg and got green on all apps on hub and spoke
dminnear-rh
approved these changes
Apr 15, 2026
Contributor
dminnear-rh
left a comment
dminnear-rh
left a comment
There was a problem hiding this comment.
One comment but you can take it or leave it. PR is good to go regardless!
| name: vault-backend | ||
| kind: ClusterSecretStore | ||
|
|
||
| esoversion: "external-secrets.io/v1beta1" |
Contributor
There was a problem hiding this comment.
do we still want to keep this value around? the new ESO operator only supports external-secrets.io/v1 so maybe we just hard code that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on mcg and got green on all apps on hub and spoke