Added 'disableSelectStartList' to disable select start on certain items#81
Open
davemckenna01 wants to merge 1 commit intovalerybugakov:masterfrom
Open
Added 'disableSelectStartList' to disable select start on certain items#81davemckenna01 wants to merge 1 commit intovalerybugakov:masterfrom
davemckenna01 wants to merge 1 commit intovalerybugakov:masterfrom
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/skymk1/react-selectable-fast/3g5njhfco |
|
Any status of getting this in? I'm very interested in this functionality! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I love your package. I wanted my selectables to be draggable without having to disable the SelectableGroup (to get selectable and draggable behaviour like the files/folders in an OS GUI like Windows/Mac etc). To achieve this I sort of mimicked how you implemented the ignore list. So with this PR, if you try to start a lasso drag on a selectable item that has a certain class, you won't be able to.
If you like this addition feel free to merge it. If you need anything else from me, like code convention clean up, testing, anything at all, let me know.
Again, thanks for your package.