mountpoint: check the target path parent#547
Open
favilances wants to merge 1 commit intouutils:mainfrom
Open
Conversation
mountpoint determines whether a path is a mount point by comparing it with its parent. The implementation was checking the process working directory's parent instead, which could make regular directories look like mount points. Use the target path parent for the comparison and return util-linux's non-mountpoint exit status so this behavior is covered by a focused regression test. Signed-off-by: favilances <favilances@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
mountpointso it compares the target path with the target path's parent instead of the process working directory's parent.Motivation
The previous check could report regular directories such as
/etcas mount points when the current working directory lived on a different filesystem. util-linux reports non-mountpoints with exit status 32, so this also returns that status for non-mountpoint paths.Fixes #366.
Testing
cargo test test_mountpoint --features mountpointcargo clippy --all-targets --features mountpointcargo fmt --checkcargo testNote:
cargo clippy --all-targets --all-featuresstill fails on currentmainbecauseuudocis missing direct dependency declarations forzipanduuhelp_parser; that is handled separately in #546.