sort : gnu core utils test (sort-merge-fdlimit.sh) #9849

mattsu2020 · 2025-12-25T23:32:56Z

Modifications were made to pass the GNU coreutils tests.

github-actions · 2025-12-25T23:55:53Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

src/uu/sort/Cargo.toml

src/uu/sort/src/sort.rs

sylvestre · 2025-12-26T00:03:27Z

some jobs are failing and please add tests

codspeed-hq · 2025-12-26T00:16:55Z

Merging this PR will degrade performance by 13.16%

⚡ 29 improved benchmarks
❌ 6 regressed benchmarks
✅ 247 untouched benchmarks
⏩ 38 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Memory	`sort_dictionary_order[500000]`	42 MB	29.7 MB	+41.6%
❌	Memory	`sort_accented_data[500000]`	22.1 MB	25.5 MB	-13.15%
⚡	Memory	`sort_numeric_utf8_locale`	8.8 MB	4.2 MB	×2.1
⚡	Memory	`sort_ascii_c_locale`	8.3 MB	6.1 MB	+36.75%
❌	Memory	`sort_mixed_data[500000]`	22.9 MB	25.9 MB	-11.49%
⚡	Memory	`sort_german_de_locale`	5.3 MB	3.6 MB	+49.49%
⚡	Memory	`sort_german_c_locale`	5.3 MB	3.6 MB	+49.49%
⚡	Memory	`sort_mixed_utf8_locale`	3.5 MB	2.6 MB	+34.7%
⚡	Memory	`sort_reverse_utf8_locale`	3 MB	2.6 MB	+13.59%
⚡	Memory	`sort_ascii_utf8_locale`	6.7 MB	5.6 MB	+19.8%
⚡	Memory	`sort_case_sensitive[500000]`	16.9 MB	16.3 MB	+3.41%
⚡	Memory	`sort_numeric[500000]`	75.5 MB	48.7 MB	+54.97%
❌	Memory	`sort_ascii_only[500000]`	22.2 MB	25.5 MB	-13.16%
❌	Memory	`sort_long_line[160000]`	712.6 KB	738.3 KB	-3.48%
⚡	Memory	`sort_reverse_locale[500000]`	27.5 MB	21.6 MB	+27.63%
⚡	Memory	`sort_unique_utf8_locale`	4.7 MB	3.8 MB	+24%
⚡	Memory	`sort_case_insensitive[500000]`	16.9 MB	16.3 MB	+3.45%
❌	Memory	`sort_unique_locale[500000]`	33.6 MB	36.9 MB	-9.08%
⚡	Memory	`sort_general_numeric[200000]`	43.2 MB	23.6 MB	+83.04%
⚡	Memory	`sort_key_field[500000]`	47.8 MB	32.8 MB	+45.74%
...	...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

_{Comparing mattsu2020:sort/sort-merge-fdlimit.sh (331b144) with main (2c75e71)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-26T05:39:36Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2025-12-29T10:19:40Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2025-12-29T11:05:40Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

sylvestre · 2025-12-29T15:02:43Z

please have a look to the perf regression, 9% is a bit too much

github-actions · 2025-12-30T13:10:06Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-05T11:58:43Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T04:16:55Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T04:45:05Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T04:54:12Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T05:50:46Z

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/tail/follow-name is no longer failing!

github-actions · 2026-01-06T09:20:22Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-06T10:21:06Z

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/tty/tty-eof is no longer failing!

github-actions · 2026-01-06T10:47:51Z

GNU testsuite comparison:

Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

github-actions · 2026-01-06T11:25:13Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

github-actions · 2026-01-14T09:10:17Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

- Use libc::fcntl for invalid fd probing to avoid errors - Make ctrlc/signal handling conditional on Redox - Skip fd soft-limit checks on unsupported Unix variants - Allow FreeBSD-specific clippy allowances where needed

- Reuse a per-chunk token buffer to reduce allocations - Track a line_count_hint and reserve capacities efficiently - Compute exact line counts for small chunks or unknown hints - Skip tokenization/data extraction when settings do not need it

- Ensure /usr/local/etc/pkg/repos exists before writing config - Write FreeBSD pkg repo configuration in both jobs - Force a repo update by removing stale package db

- Bump multiple crates in Cargo.lock for bugfixes and security updates - Refresh deny.toml exceptions as needed

github-actions · 2026-01-14T10:47:04Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

github-actions · 2026-01-15T12:34:18Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

Updated various Rust crates to latest versions, including cc (1.2.51 -> 1.2.52), chrono (0.4.42 -> 0.4.43), flate2 (1.1.5 -> 1.1.8), getrandom (0.2.16 -> 0.2.17), indexmap (2.12.1 -> 2.13.0), and others. Removed unused 'arbitrary' and 'derive_arbitrary' packages. Adjusted dependencies in flate2 to use 'zlib-rs' instead of 'libz-rs-sys'. This ensures compatibility and incorporates recent bug fixes and improvements.

github-actions · 2026-01-15T13:26:43Z

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/sort/sort-merge-fdlimit is no longer failing!

sylvestre reviewed Dec 26, 2025

View reviewed changes

src/uu/sort/Cargo.toml Outdated Show resolved Hide resolved

sylvestre reviewed Dec 26, 2025

View reviewed changes

src/uu/sort/src/sort.rs Outdated Show resolved Hide resolved

sylvestre reviewed Dec 26, 2025

View reviewed changes

src/uu/sort/src/sort.rs Outdated Show resolved Hide resolved

ChrisDryden mentioned this pull request Dec 26, 2025

GNU coreutils 9.9: Detailed Test report 12/19 #9729

Open

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from a7a24fa to cafb3ca Compare January 5, 2026 10:55

mattsu2020 marked this pull request as draft January 5, 2026 23:27

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from d4c4389 to 1a1eabd Compare January 6, 2026 04:35

mattsu2020 marked this pull request as ready for review January 6, 2026 11:44

feat(sort): add --random-source option

3b86047

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from 9e9b311 to 9853dd5 Compare January 14, 2026 08:40

mattsu2020 added 2 commits January 14, 2026 19:18

compat(sort): improve fd handling on nonstandard platforms

f09e8a8

- Use libc::fcntl for invalid fd probing to avoid errors - Make ctrlc/signal handling conditional on Redox - Skip fd soft-limit checks on unsupported Unix variants - Allow FreeBSD-specific clippy allowances where needed

mattsu2020 added 2 commits January 14, 2026 19:18

ci: fix FreeBSD pkg repo setup

ea77daa

- Ensure /usr/local/etc/pkg/repos exists before writing config - Write FreeBSD pkg repo configuration in both jobs - Force a repo update by removing stale package db

chore(deps): update Rust dependencies

7c5749f

- Bump multiple crates in Cargo.lock for bugfixes and security updates - Refresh deny.toml exceptions as needed

mattsu2020 force-pushed the sort/sort-merge-fdlimit.sh branch from 9853dd5 to 7c5749f Compare January 14, 2026 10:22

Merge branch 'main' into sort/sort-merge-fdlimit.sh

67b6c38

Uh oh!

sort : gnu core utils test (sort-merge-fdlimit.sh) #9849

Are you sure you want to change the base?

sort : gnu core utils test (sort-merge-fdlimit.sh) #9849

Uh oh!

Conversation

mattsu2020 commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sylvestre commented Dec 26, 2025

Uh oh!

codspeed-hq bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 13.16%

Performance Changes

Footnotes

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

sylvestre commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Dec 26, 2025 •

edited

Loading